Skip to content

fix: source map warnings and TS6059 errors in workspace setups #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbrandes merged 2 commits into from
Aug 30, 2026
Merged

fix: source map warnings and TS6059 errors in workspace setups #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e20177
fix: silence unparseable third-party source map warnings
arbrandes Aug 30, 2026
533b953
fix: keep rootDir out of the tsconfig ts-loader reads
arbrandes Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"pack": "mkdir -p pack && npm pack --silent --pack-destination pack >/dev/null && mv \"$(ls -t pack/*.tgz | head -n 1)\" pack/openedx-frontend-base.tgz",
"prepack": "npm run build",
"test": "jest",
"typecheck": "tsc --noEmit -p tsconfig.json && tsc --noEmit -p tools/tsconfig.json",
"typecheck": "tsc --noEmit -p tsconfig.typecheck.json && tsc --noEmit -p tools/tsconfig.json",
"watch:build": "nodemon --exec 'npm run build'",
"watch:docs": "nodemon --watch docs/template --watch README.md --exec npm run docs",
"watch:pack": "nodemon --exec 'npm run pack'",
Expand Down
1 change: 1 addition & 0 deletions tools/webpack/webpack.config.build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const resolvedSiteI18nPath = getResolvedSiteI18nPath('src/i18n');
const config: Configuration = {
mode: 'production',
devtool: 'source-map',
ignoreWarnings: [/Failed to parse source map/],
entry: {
cssLayerOrder: '@openedx/frontend-base/shell/layer-order.scss',
app: '@openedx/frontend-base/shell/site',
Expand Down
3 changes: 1 addition & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"extends": "./tools/typescript/tsconfig.json",
"compilerOptions": {
"outDir": "dist",
"rootDir": "."
"outDir": "dist"
},
"include": [
"runtime/**/*",
Expand Down
6 changes: 6 additions & 0 deletions tsconfig.typecheck.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"rootDir": "."
}
}