fix: typecheck test files in CI - #304
Merged
Merged
Conversation
Nothing in CI typechecked test files, so type errors in *.test.ts and *.test.tsx could land on main unnoticed. The build config excludes them and jest transpiles through Babel, which does no typechecking. Fixes openedx#294 Co-Authored-By: Claude <noreply@anthropic.com>
|
🎉 This PR is included in version 2.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nothing in CI typechecked test files, so type errors in
*.test.tsand*.test.tsxcould land on main unnoticed.tsconfig.build.jsonexcludes test files from the build, andnpm run testtranspiles through Babel, which does no typechecking.This adds an
npm run typecheckscript and a corresponding CI step. It covers the root project (runtime/,shell/) andtools/, whose tsconfigs already include their test files. TherootDiraddition totsconfig.jsonis what makestsc -p tsconfig.jsonrunnable at all: without it, the self-referencing@openedx/frontend-baseimports inshell/make the project root ambiguous when resolving the package's own exports map. It is a no-op for the build, which already infers the same value.test-siteis left alone, since its test files are already typechecked byfork-ts-checker-webpack-pluginduring the existingBuild Test Sitestep.Fixes #294
LLM usage notice
Built with assistance from Claude.