fix: fail npm run lint when eslint reports errors - #303
Merged
Conversation
The lint script chained its commands with semicolons, so it exited with the status of the last one and CI stayed green with lint errors present. Fixes openedx#295 Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
enabled auto-merge (rebase)
August 29, 2026 13:01
|
🎉 This PR is included in version 2.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
lintscript chained its three commands with;, sonpm run lintexited with the status of the last command only and CI stayed green with lint errors present. Bothlintandlint:fixnow chain with&&.One consequence:
npm run lint:fixstops beforetools/if the root--fixpass leaves unfixable errors. Re-run it after fixing those by hand.Fixes #295
LLM usage notice
Built with assistance from Claude.