ci: add scheduled runs for release branches - #5393
Merged
Merged
Conversation
Somehow we missed adding release-1.4 and release-1.5 branches to scheduled CI runs (added in commit 995a39a). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Member
|
This needs to be cherry-picked as well for it to be applied to each of those branches). |
Contributor
Author
I think this doesn't work like this (and I already explained why in PR description above, as well as in the yml file itself). |
lifubang
approved these changes
Aug 13, 2026
lifubang
left a comment
lifubang
left a comment
Member
There was a problem hiding this comment.
LGTM with one suggestion, and I think we can implement it in a follow-up PR.
| strategy: | ||
| matrix: | ||
| branch: ["main", "release-1.3"] | ||
| branch: ["main", "release-1.5", "release-1.4", "release-1.3"] |
Member
There was a problem hiding this comment.
One thing to consider: the branch matrix is hardcoded, so every time we cut a new minor release we'll need to remember to update this list (e.g. when 1.6 is released: add release-1.6, drop release-1.3 which falls out of support per RELEASES.md). To avoid forgetting that, two suggestions:
- Add a reminder comment in this file;
- we could make the matrix dynamic: a prep job lists the repo branches via the GitHub API, picks the 3 newest release-X.Y branches (matching the latest / latest-1 / latest-2 policy), and feeds them to the matrix.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow we missed adding release-1.4 and release-1.5 branches to scheduled CI runs (added in commit 995a39a).
AFAIR this does not need to be backported (scheduled jobs are only run on main branch).