Remove golangci-lint - #1337
Open
sudo-bmitch wants to merge 1 commit into
Open
Conversation
This linter is Go version dependent, and results in more maintenance overhead than code fixes. Instead, this switches to "go fmt" and "go vet" for some minimal compiler checks. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
cyphar,
jonjohnsonjr,
sajayantony,
stevvooe and
tianon
as code owners
August 21, 2026 15:03
tianon
reviewed
Aug 22, 2026
Comment on lines
+90
to
+92
| @test -z "$(go fmt ./...)" | ||
| @test -z "$(go vet ./...)" | ||
| @[ "$$BUILD_SPEC_MODULE_ONLY" = true ] || ( cd schema && test -z "$(go fmt ./...)" && test -z "$(go vet ./...)" ) |
Member
There was a problem hiding this comment.
Why capturing? Both command return non-zero with useful output IME when they're just run (and they both support -C):
Suggested change
| @test -z "$(go fmt ./...)" | |
| @test -z "$(go vet ./...)" | |
| @[ "$$BUILD_SPEC_MODULE_ONLY" = true ] || ( cd schema && test -z "$(go fmt ./...)" && test -z "$(go vet ./...)" ) | |
| @go fmt ./... | |
| @go vet ./... | |
| @[ "$$BUILD_SPEC_MODULE_ONLY" = true ] || { go -C schema fmt ./... && go -C schema vet ./...; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint was Go version dependent to build, and resulted in more maintenance overhead than code fixes. Instead, this switches to "go fmt" and "go vet" for some minimal compiler checks.