Bind reports to exact target identity - #95
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs changes before merge. Reviewed August 26, 2026, 4:29 PM ET / 20:29 UTC. ClawSweeper reviewWhat this changesThe PR adds integrity-backed identity metadata for exact npm runtime targets to Kova reports, JSON receipts, and artifact bundle manifests. Merge readinessKeep open: the integrity-binding implementation and OCM-backed proof are useful, but the still-unfixed P3 documentation example promises a null field that moving-selector reports do not emit. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherKova executes OpenClaw runtime scenarios and emits reports, CLI receipts, and artifact bundles for evidence consumers. Target selection feeds an optional identity record into each output surface. flowchart LR
A[Target selector] --> B[Target planning]
B --> C[Runtime identity lookup]
C --> D[Run report]
D --> E[JSON receipt]
D --> F[Artifact bundle]
E --> G[Evidence consumer]
F --> G
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep identity optional for moving selectors and remove Do we have a high-confidence way to reproduce the issue? Yes. Source inspection establishes that moving selectors resolve to no identity while the generic moving-selector documentation shows a null-valued field. Is this the best way to solve the issue? No. The implementation and schema example need one consistent optional-field contract; omitting the field from the generic example is the narrowest repair. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1fe2f4081877. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (9 earlier review cycles; latest 8 shown)
|
|
Fixed on exact HEAD @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Contributor-side work is complete on exact HEAD
The durable ClawSweeper comment/labels still show the previous head because its publication step did not update the PR, but the review run itself completed successfully. Upstream CI is currently We are waiting for a Kova maintainer to approve/run the upstream CI and perform the normal merge review. No further contributor changes are currently indicated. |
Summary
npm:<semver>targets to the installed OCM runtime's npm integrityversion_onlytargetIdentityto reports, run and matrix receipts, and bundle manifestsThis lets downstream evidence consumers prove that the tested candidate is the candidate they intend to install.
Verification
PATH=<local-ocm>:$PATH npm run check:full— 280/280 checks passednpm run pack:release— release artifact SHA-256b51b21f0eb69ca0b0e6d8c2a9ef0d0aea3d81b34e16c5afddf35a3cf12531125Redacted OCM behavior proof
Exact HEAD:
b909e045cac8e7276fd32aee680366efb8ce3079A disposable OCM-backed execution ran
release-runtime-startupagainst exact targetnpm:2026.7.1-2:kova-260823-221103-b5f536sha512; decoded length:64bytessha256:9fb2f91a06e694c9eea4309901ecb170c584e1f09f85689fe13a312ea4ae47catruea659fa8d03c2206e214aac5a29f994ede92eee6b3ddf2e39fa8b1ba94fdac60eThe scenario itself remained
FAILbecause cold readiness was 32,927 ms against a 30,000 ms performance threshold. That unrelated performance failure is retained rather than presented as a green scenario.