Wire list_of_unit through visitor/exporter pipeline#15
Merged
Conversation
The importer recognized list_of_unit entities (v0.2.2) but the visitor/exporter pipeline silently dropped them — no visit method, no JSON payload builder, no dedicated entity class. Changes: - New Opencdd::ListUnit < Entity entity class - MetaClasses MDC_C0100 entity_class changed from Entity to ListUnit - Database#list_of_units type-partitioned accessor - Visitor#visit_list_of_units + #visit_list_of_unit - Exporters::Json: visit_list_of_unit override + PAYLOAD_BUILDERS entry + list_of_unit_node method 13 new specs covering: class hierarchy, meta-class registration, Database accessor, Visitor traversal, JSON export (to_json includes list_of_unit entries with preferred_name, payload_for dispatch). Follows the existing OCP pattern: adding a new entity type = one class + one registry entry + one visitor method + one exporter node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The importer recognized
list_of_unitentities (v0.2.2) but the visitor/exporter pipeline silently dropped them. This wires the full pipeline:Opencdd::ListUnit < Entityentity classDatabase#list_of_unitstype-partitioned accessorVisitor#visit_list_of_units+#visit_list_of_unitExporters::Json:visit_list_of_unit+PAYLOAD_BUILDERSentry +list_of_unit_nodemethodOpencdd::ListUnitinstead of genericEntityTest plan