Fix the rake workflow on Ubuntu and Windows runners#12
Open
suleman-uzair wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes both platform failures in the
rakeworkflow. Ubuntu jobs ran all 882 examples green and then aborted inlint:registry—bin/lint-no-raw-mdchas no shebang line, so runners execute it with/bin/sh(dash), which rejectsset -o pipefail. Windows jobs never get that far:actions/checkoutfails withinvalid pathbecause one tracked filename starts with\x05, a character Windows forbids in paths.Changes
#!/usr/bin/env bashtobin/lint-no-raw-mdc— the script uses bash-only syntax (pipefail, arrays), and macOS runners passed only because/bin/shis bash there.reference-docs/parcelmaker/Parcel Maker5.2.1/\x05SummaryInformationtoSummaryInformation— the\x05prefix is Microsoft's reserved OLE stream name, written to disk verbatim when the ParcelMaker MSI was unpacked; git records a 100% rename and the original.msistays tracked alongside, so no reference content is lost.