fix(tui): open select screen on what the user actually chose#154
Merged
Conversation
Picking a loadout opened the select screen on catCur 0 — whichever catalog category happens to sit first — instead of on the packages the loadout picked. On a machine with everything already installed this left every sidebar row showing a flat grey count with no way to find the selection, and pressing space on the wrong-focused pane toggled a row with no visible cursor. Pin a synthetic "selected" review category first in the sidebar so the screen opens on the answer to its own question. Sidebar counts now separate "selected" from "still to install" instead of collapsing them, and space is a no-op while the sidebar (not the list) holds focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catCur 0— whichever catalog category happens to sit first (essential) — instead of on the packages the loadout picked. Reported from VM testing: on a machine with everything already installed, every sidebar row showed a flat grey count with no way to find the actual selection.selectedreview category first in the sidebar so the screen opens on the answer to its own question (the enter key installs, so the cursor should land on what's about to be installed).Test plan
go build ./...go vet ./...make test-unit— full L1 (unit + integration + contract), all greenTestSelectOpensOnReviewCategory,TestHandPickSkipsReviewCategory,TestConfigModeSkipsReviewCategory,TestSpaceIgnoredWhileSidebarFocused,TestSidebarCountShowsSelectedEvenWhenAllInstalled,TestReviewCategoryRefreshesOnReentryselected 48/48with the cursor on the 48 chosen packages