fix(tui): stop saying "openboot" twice on the boot screen#153
Merged
Conversation
The title bar reads "▲ openboot v0.66.2" and the body opened, one row below it, with a wordmark reading "openboot". Same word, twice, three lines apart — and a row spent on it. The frame is what names the product; it's on every screen. The wordmark was a splash element that only repeated what the frame already said, so it goes. The tagline stays: "zero → dev-ready, in one command" is the only part of that block that told you anything. bootHitTest's geometry mirrors the render row-for-row, so it moves with it (4 header rows → 3). The two mouse tests hardcode screen rows and caught the shift on the first run, which is what they're for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the boot screen's wordmark, which repeated the name the title bar had already printed one row above.
Why?
Reported from a real run on v0.66.2:
The title bar is persistent chrome — it's on every screen, and it already carries the name and version. The wordmark was a splash element that added nothing except a second copy of the word and a spent row. The tagline is the only line in that block that says something, so the body now opens with it:
Testing
go vet ./...passesbootHitTest's geometry mirrors the render row-for-row, so removing a row moves the loadout rows up one.TestBootMouseClickPicksLoadoutandTestBootMouseHoverHighlightsLoadouthardcode screen rows and both failed on the first run, which is exactly what they're there for; updated with the new geometry.Notes for reviewer
wordmark()had no other caller, so it's deleted rather than left forunusedto flag.