fix: make diff-scan writeups and hardening optional - #272
Conversation
|
@codex review Please review the exact current head |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…can-lifecycle-metadata
…elo/codex/sync-cross-worker-token-usage
…gelo/codex/repair-deep-scan-schema
…odex/unify-deep-scan-phases
…dex/sync-live-scan-context
…dex/preserve-url-scan-context
…/codex/model-native-deep-workers
…/codex/repair-workbench-migration-collisions
…nto mdangelo/codex/optional-diff-scan-artifacts
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review the exact updated head |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…gelo/codex/repair-deep-scan-schema
There was a problem hiding this comment.
💡 Codex Security Review
Adding --no-ignore makes the standard-scan inventory include every .gitignored path, not just ignored tracked files. In a normal repo with .env or ignored dependency trees, prepareCodexSecurityReviewItems feeds those paths into the worklist, and the scan workflow tells the agent to review every returned source file. That can put local credential files into model context without explicit authorization. Use a Git-aware inventory for tracked ignored files, or keep default ignore handling and add tracked ignored paths separately.
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
…odex/unify-deep-scan-phases
…dex/sync-live-scan-context
…dex/preserve-url-scan-context
…/codex/model-native-deep-workers
…/codex/repair-workbench-migration-collisions
…nto mdangelo/codex/optional-diff-scan-artifacts
|
@codex review Please review the exact updated head |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The base branch was changed.
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Stack
mdangelo/codex/repair-workbench-migration-collisionsso this review contains only its atomic upstream change.Verification