Skip to content

fix: make diff-scan writeups and hardening optional - #272

Merged
mldangelo-oai merged 52 commits into
mainfrom
mdangelo/codex/optional-diff-scan-artifacts
Aug 4, 2026
Merged

fix: make diff-scan writeups and hardening optional#272
mldangelo-oai merged 52 commits into
mainfrom
mdangelo/codex/optional-diff-scan-artifacts

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

  • Make optional vulnerability writeups and hardening portfolios genuinely optional for diff scans.
  • Align diff-scan instructions with the artifact contract without weakening required canonical scan outputs.

Stack

  • Intentionally stacked on mdangelo/codex/repair-workbench-migration-collisions so this review contains only its atomic upstream change.
  • Prerequisite for the pending 0.1.6 release in release: bump Codex Security to 0.1.6 #244; package version is unchanged.

Verification

  • Parsed every bundled workbench Python module.
  • Verified all 105 declared plugin payload files exist.
  • Initialized a fresh private workbench SQLite database successfully.
  • Passed Prettier for all 2 changed formatted files.
  • The complete reconstructed sync passed 775 tests (5 platform/integration skips) and the installed-package smoke test.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the exact current head f9cd6846c9a1f0c54bca55ec449de34de1818082 and only this atomic PR's declared base-to-head diff.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: f9cd6846c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: f9cd6846c9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

…/codex/repair-workbench-migration-collisions
…nto mdangelo/codex/optional-diff-scan-artifacts
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the exact updated head 4c6763e289169c83ab73021a45d1b6a58f409a3d. This additive update ships the exact generated MCP runtime from the same original upstream commit and preserves the atomic base-to-head diff.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: c68a301674

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Security Review

command = ["rg", "--files", "--hidden", "--no-ignore", "--glob", "!.git/**", "--", scope]

P2 Badge Security: Keep ignored secrets out of scan inventories

Adding --no-ignore makes the standard-scan inventory include every .gitignored path, not just ignored tracked files. In a normal repo with .env or ignored dependency trees, prepareCodexSecurityReviewItems feeds those paths into the worklist, and the scan workflow tells the agent to review every returned source file. That can put local credential files into model context without explicit authorization. Use a Git-aware inventory for tracked ignored files, or keep default ignore handling and add tracked ignored paths separately.

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the exact updated head d24c063f41051bd95f2ea30f7717598f2b352004. Inherits regression-tested resumable finalization, accurate cached-token totals, distinct canonical finding identities, complete ignored-file coverage, safe context delegation, and preserved prompt/headless scan identity; the generated runtime remains matched to this original atomic upstream stage.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: d24c063f41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: d24c063f41

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

kmbroai
kmbroai previously approved these changes Aug 4, 2026
ianw-oai
ianw-oai previously approved these changes Aug 4, 2026
Base automatically changed from mdangelo/codex/repair-workbench-migration-collisions to main August 4, 2026 19:48
@mldangelo-oai
mldangelo-oai dismissed stale reviews from ianw-oai and kmbroai August 4, 2026 19:48

The base branch was changed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 4, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: e65018c72b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: e65018c72b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mldangelo-oai
mldangelo-oai merged commit 7e95bb0 into main Aug 4, 2026
21 of 22 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/optional-diff-scan-artifacts branch August 4, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants