Skip to content

[codex-security] cut npm releases only after public CI succeeds - #235

Open
soyeon-oai wants to merge 4 commits into
mainfrom
codex/codsec-release-after-public-ci
Open

[codex-security] cut npm releases only after public CI succeeds#235
soyeon-oai wants to merge 4 commits into
mainfrom
codex/codsec-release-after-public-ci

Conversation

@soyeon-oai

Copy link
Copy Markdown
Contributor

Summary

  • Keep npm release orchestration in the public repository.
  • Start the release cut only after node-ci succeeds on main, while preserving manual dispatch.
  • Check out and tag the exact successful CI commit and preserve existing release safety checks.
  • Add public Bun regressions for the workflow trigger and exact release commit.

Testing

  • bun test sdk/typescript/tests-ts/release-cut-workflow.test.ts
  • YAML parsing and workflow trigger assertions

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if [[ "$version" == "$previous_version" ]]; then
echo "Package version is unchanged; no release is needed."
echo "changed=false" >> "$GITHUB_OUTPUT"
exit 0

P1 Badge Don't skip an unpublished version after a follow-up fix

When a version-bump commit fails CI and a subsequent fix commit succeeds without changing package.json, the successful run sees the same version in its immediate parent and exits here before checking npm. The fixed, CI-validated commit is therefore never tagged or published, and further unrelated commits also skip it; only another version bump or manual dispatch can recover the release. Confirm that the current version is already published before treating an unchanged manifest as a no-op.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants