fix(python): preserve explicit virtualenv launchers - #227
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194
Summary
Root cause
The trusted-executable boundary used
realpath()both to validate and to invoke every explicit path. On POSIX, a virtualenv'sbin/pythonis commonly a symlink to the system interpreter. Executing that canonical target bypassed the virtualenv'ssite-packages, so Python 3.10 could no longer import the requiredtomlipackage.Impact
Documented
pythonPath,--python, andPYTHONvalues can point to a Python 3.10 virtualenv without losing its installed packages. PATH sanitization and repository-controlled executable protections remain intact.Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/trusted-executable.test.ts— 5 passed, 1 platform skippnpm exec tsc --noEmitpnpm exec prettier --check src/trusted-executable.ts tests-ts/runtime.test.tsgit diff --check