test(release): select Git Bash explicitly on Windows - #225
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206
Summary
Root cause
The release-automation tests invoked an unqualified
bash. When Windows resolvedC:\\Windows\\System32\\bash.exefirst, the workflow fragments crossed into WSL and lost the Windows command and path environment expected by the test harness.Impact
Enabling WSL or placing its compatibility executable earlier on
PATHno longer causes the release-workflow test suite to select the wrong shell. POSIX test behavior is unchanged.Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/release-automation.test.ts --test-name-pattern "uses Git Bash for shell fragments on Windows|executes the manual release cut against all published versions"— 2 passedpnpm exec tsc --noEmitpnpm exec prettier --check tests-ts/release-automation.test.tsgit diff --check