Skip to content

test(release): select Git Bash explicitly on Windows - #225

Open
dipeshbabu wants to merge 1 commit into
openai:mainfrom
dipeshbabu:agent/fix-release-tests-git-bash
Open

test(release): select Git Bash explicitly on Windows#225
dipeshbabu wants to merge 1 commit into
openai:mainfrom
dipeshbabu:agent/fix-release-tests-git-bash

Conversation

@dipeshbabu

Copy link
Copy Markdown
Contributor

Fixes #206

Summary

  • Resolve Git Bash from Git for Windows' own executable directory.
  • Invoke that absolute executable for every release-workflow shell test on Windows.
  • Add a regression check that verifies the selected shell is a MinGW Git Bash process.

Root cause

The release-automation tests invoked an unqualified bash. When Windows resolved C:\\Windows\\System32\\bash.exe first, the workflow fragments crossed into WSL and lost the Windows command and path environment expected by the test harness.

Impact

Enabling WSL or placing its compatibility executable earlier on PATH no longer causes the release-workflow test suite to select the wrong shell. POSIX test behavior is unchanged.

Validation

  • pnpm dlx bun test --timeout 30000 ./tests-ts/release-automation.test.ts --test-name-pattern "uses Git Bash for shell fragments on Windows|executes the manual release cut against all published versions" — 2 passed
  • pnpm exec tsc --noEmit
  • pnpm exec prettier --check tests-ts/release-automation.test.ts
  • git diff --check

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows release tests invoke WSL bash instead of Git Bash when WSL is first on PATH

1 participant