[CONFIGURATION] Decouple SDK includes from builder interface classes - #4355
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 450 450
Lines 19216 19216
=======================================
Hits 15537 15537
Misses 3679 3679
🚀 New features to boost your workflow:
|
dbarker
marked this pull request as ready for review
August 4, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #4352
Follow up to #4335 to continue breaking dependencies between
configuration_coreand the SDK signal libraries.The goal is to decouple the abstract builder headers from the SDK component headers. After this change, including an abstract builder header no longer pulls in the SDK headers of the component it builds. The SDK type is forward declared. The requirement for the complete type is deferred to the translation units that implement or invoke a builder, which by definition already include the concrete SDK header and link that signal's library.
This makes the contract for
configuration_coremore explicit in that it provides theabstract builder headers without transitively providing the SDK signal headers.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes