Update 1.26.40 - #156
Merged
Merged
Conversation
Bumps the gophertunnel submodule to the merge of upstream sandertv/gophertunnel, which brings the 1.26.40 protocol update. PlayerList's ActionType moved onto each protocol.PlayerListEntry in 1.26.40, so the transfer proxy's state tracker reads and writes it per entry now.
📝 WalkthroughWalkthroughUpdated protocol dependencies and the gophertunnel submodule. Adapted anticheat packet, recipe, item, collision, and movement handling. Updated transferproxy player-list action processing and tests. ChangesProtocol compatibility
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@anticheat/player/detection/bad_packet_g.go`:
- Around line 58-65: In anticheat/player/detection/bad_packet_g.go at lines
58-65, use the presence boolean returned by ItemInteractionData.Value() and call
d.FailDetection when the flagged value is absent, then retain the block-face
validation for present data; also reject absent BlockActions when
InputFlagPerformBlockActions is set. In
anticheat/player/detection/bad_packet_c.go at lines 65-66, gate BlockActions on
InputFlagPerformBlockActions and call d.FailDetection when its value is absent.
In anticheat/player/detection/bad_packet_d.go at lines 51-52, reject an absent
ItemStackRequest when InputFlagPerformItemStackRequest is set.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 46f15eaf-5aa0-47fa-a0a9-a6c9abfd99fb
⛔ Files ignored due to path filters (4)
anticheat/example/default/go.sumis excluded by!**/*.sumanticheat/example/dragonfly/go.sumis excluded by!**/*.sumanticheat/go.sumis excluded by!**/*.sumexample-proxy/go.sumis excluded by!**/*.sum
📒 Files selected for processing (21)
anticheat/example/default/go.modanticheat/example/dragonfly/go.modanticheat/go.modanticheat/player/component/acknowledgement/chunks.goanticheat/player/component/entities.goanticheat/player/component/inventory.goanticheat/player/component/world.goanticheat/player/detection/bad_packet_c.goanticheat/player/detection/bad_packet_d.goanticheat/player/detection/bad_packet_g.goanticheat/player/items.goanticheat/player/packet.goanticheat/player/player.goanticheat/player/world.goanticheat/utils/collisions/collisions.goanticheat/utils/item.goexample-proxy/go.modgophertunneltransferproxy/go.modtransferproxy/proxy_test.gotransferproxy/state_tracker.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Compatibility
Bug Fixes
Maintenance