Skip to content

Update 1.26.40 - #156

Merged
NopeNotDark merged 2 commits into
stablefrom
update-1.26.40
Aug 11, 2026
Merged

Update 1.26.40#156
NopeNotDark merged 2 commits into
stablefrom
update-1.26.40

Conversation

@NopeNotDark

@NopeNotDark NopeNotDark commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Compatibility

    • Updated protocol and networking support for newer game-server versions.
    • Improved handling of optional packet fields, chunk requests, movement teleports, player lists, and block actions.
  • Bug Fixes

    • Improved chunk decoding error handling and safely disconnects affected players.
    • Fixed crafting recipe matching across supported recipe types.
    • Improved item and collision processing reliability.
  • Maintenance

    • Updated networking and server integration components across examples and proxy modules.

ethaniccc and others added 2 commits August 5, 2026 16:27
Bumps the gophertunnel submodule to the merge of upstream
sandertv/gophertunnel, which brings the 1.26.40 protocol update.

PlayerList's ActionType moved onto each protocol.PlayerListEntry in
1.26.40, so the transfer proxy's state tracker reads and writes it per
entry now.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated protocol dependencies and the gophertunnel submodule. Adapted anticheat packet, recipe, item, collision, and movement handling. Updated transferproxy player-list action processing and tests.

Changes

Protocol compatibility

Layer / File(s) Summary
Dependency and submodule updates
anticheat/*/go.mod, example-proxy/go.mod, transferproxy/go.mod, gophertunnel
Updated Dragonfly, go-raknet, and gophertunnel revisions. Removed nxadm/tail, added fsnotify, and advanced the gophertunnel submodule.
Optional packet field handling
anticheat/player/component/..., anticheat/player/detection/..., anticheat/player/packet.go, anticheat/player/world.go
Packet handlers now unwrap optional payloads, requests, block actions, window IDs, and subchunk modes before processing.
Recipe, item, and collision adaptation
anticheat/player/component/inventory.go, anticheat/player/items.go, anticheat/player/packet.go, anticheat/player/player.go, anticheat/utils/...
Recipe storage supports separate recipe types. Item NBT decoding uses public APIs. Collision lookup no longer uses a cache.
Player-list action handling
transferproxy/state_tracker.go, transferproxy/proxy_test.go
Player-list tracking and cleanup now use per-entry action types. Tests use protocol-level constants and fields.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested reviewers: ethaniccc

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change as updating the project for version 1.26.40.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-1.26.40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@anticheat/player/detection/bad_packet_g.go`:
- Around line 58-65: In anticheat/player/detection/bad_packet_g.go at lines
58-65, use the presence boolean returned by ItemInteractionData.Value() and call
d.FailDetection when the flagged value is absent, then retain the block-face
validation for present data; also reject absent BlockActions when
InputFlagPerformBlockActions is set. In
anticheat/player/detection/bad_packet_c.go at lines 65-66, gate BlockActions on
InputFlagPerformBlockActions and call d.FailDetection when its value is absent.
In anticheat/player/detection/bad_packet_d.go at lines 51-52, reject an absent
ItemStackRequest when InputFlagPerformItemStackRequest is set.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 46f15eaf-5aa0-47fa-a0a9-a6c9abfd99fb

📥 Commits

Reviewing files that changed from the base of the PR and between d0ae3f1 and 427c04f.

⛔ Files ignored due to path filters (4)
  • anticheat/example/default/go.sum is excluded by !**/*.sum
  • anticheat/example/dragonfly/go.sum is excluded by !**/*.sum
  • anticheat/go.sum is excluded by !**/*.sum
  • example-proxy/go.sum is excluded by !**/*.sum
📒 Files selected for processing (21)
  • anticheat/example/default/go.mod
  • anticheat/example/dragonfly/go.mod
  • anticheat/go.mod
  • anticheat/player/component/acknowledgement/chunks.go
  • anticheat/player/component/entities.go
  • anticheat/player/component/inventory.go
  • anticheat/player/component/world.go
  • anticheat/player/detection/bad_packet_c.go
  • anticheat/player/detection/bad_packet_d.go
  • anticheat/player/detection/bad_packet_g.go
  • anticheat/player/items.go
  • anticheat/player/packet.go
  • anticheat/player/player.go
  • anticheat/player/world.go
  • anticheat/utils/collisions/collisions.go
  • anticheat/utils/item.go
  • example-proxy/go.mod
  • gophertunnel
  • transferproxy/go.mod
  • transferproxy/proxy_test.go
  • transferproxy/state_tracker.go

Comment thread anticheat/player/detection/bad_packet_g.go
@NopeNotDark
NopeNotDark merged commit d784d4f into stable Aug 11, 2026
2 checks passed
@NopeNotDark
NopeNotDark deleted the update-1.26.40 branch August 11, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants