Skip to content

fix: stop shipping the eslint config in @oneschema/vue - #157

Merged
behnam-oneschema merged 1 commit into
mainfrom
devin/vue-npmignore
Aug 27, 2026
Merged

fix: stop shipping the eslint config in @oneschema/vue#157
behnam-oneschema merged 1 commit into
mainfrom
devin/vue-npmignore

Conversation

@behnam-oneschema

Copy link
Copy Markdown
Member

Summary

Split out of #155 (packaging hygiene only). @oneschema/vue was shipping its .eslintrc.yml in the published tarball; adds a package .npmignore excluding it, plus a patch changeset.

Test plan

Link to Devin session: https://app.devin.ai/sessions/a90df1407fe74fe990a9e3f3bfa772d3
Open in Devin Desktop: https://app.devin.ai/desktop/session/a90df1407fe74fe990a9e3f3bfa772d3?variant=devin
Requested by: @behnam-oneschema

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ea1bc6ae-940b-4a73-b145-e7ec481a8cbf

📥 Commits

Reviewing files that changed from the base of the PR and between 3816ab9 and cbffe96.

📒 Files selected for processing (2)
  • .changeset/quiet-vans-smile.md
  • packages/importer-vue/.npmignore

Limit details: You’ve used the included review currently available. Your 111 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


Walkthrough

The PR prevents @oneschema/vue from publishing .eslintrc.yml and adds a patch changeset for the package.

Changes

Package publication cleanup

Layer / File(s) Summary
Exclude ESLint configuration from package
.changeset/quiet-vans-smile.md, packages/importer-vue/.npmignore
The npm ignore rules exclude .eslintrc.yml. The changeset records a patch release for @oneschema/vue.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cbffe

This localized packaging change excludes the ESLint configuration from the published Vue package and adds the intended patch release metadata; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed PASS: The PR only adds a package .npmignore entry and a changeset. It does not change executable code, dependencies, permissions, or release workflow behavior. The existing .eslintrc.yml contains …
Title check ✅ Passed The title uses the required Conventional Commits format and accurately describes the change to stop shipping the ESLint configuration in @oneschema/vue.
Description check ✅ Passed The description clearly explains the .npmignore change, patch changeset, and npm pack verification for excluding .eslintrc.yml.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Security Check

Explanation

PASS: The PR only adds a package .npmignore entry and a changeset. It does not change executable code, dependencies, permissions, or release workflow behavior. The existing .eslintrc.yml contains lint settings only, and npm pack --dry-run --ignore-scripts confirms that the file is excluded from the package. No changed security concern is evident.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/vue-npmignore

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review August 27, 2026 07:26
@behnam-oneschema
behnam-oneschema merged commit a68ce85 into main Aug 27, 2026
2 checks passed
@behnam-oneschema
behnam-oneschema deleted the devin/vue-npmignore branch August 27, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant