fix: stop shipping the eslint config in @oneschema/vue - #157
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Limit details: You’ve used the included review currently available. Your 111 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. WalkthroughThe PR prevents ChangesPackage publication cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized packaging change excludes the ESLint configuration from the published Vue package and adds the intended patch release metadata; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Security CheckExplanation PASS: The PR only adds a package ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Split out of #155 (packaging hygiene only).
@oneschema/vuewas shipping its.eslintrc.ymlin the published tarball; adds a package.npmignoreexcluding it, plus a patch changeset.Test plan
npm pack --dry-runinpackages/importer-vue:.eslintrc.ymlexcluded (verified on ci: publish via npm trusted publishing (OIDC), changesets cli v3 #155)Link to Devin session: https://app.devin.ai/sessions/a90df1407fe74fe990a9e3f3bfa772d3
Open in Devin Desktop: https://app.devin.ai/desktop/session/a90df1407fe74fe990a9e3f3bfa772d3?variant=devin
Requested by: @behnam-oneschema