Skip to content

add enable-monitoring and timeout options for upload_firmware to the cli #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CMon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add enable-monitoring and timeout options for upload_firmware to the cli #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion onekey_client/cli/firmware_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@
@click.option(
"--sbom", help="Firmware SBOM", type=click.Path(exists=True, path_type=Path)
)
@click.option(
"--enable-monitoring",
is_flag=True,
default=False,
show_default=True,
help="Enable the monitoring for the uploaded firmware"
)
@click.option(
"--timeout",
default=60,
show_default=True,
help="Define the timeout (in s) for uploading the image"
)
@click.argument(
"filename", type=click.Path(exists=True, path_type=Path), required=False
)
Expand All @@ -48,6 +61,8 @@ def upload_firmware(
version: str | None,
name: str | None,
sbom: Path | None,
enable_monitoring : bool | False,
timeout: int | 60,
filename: Path | None,
):
"""Upload a firmware / SBOM to the ONEKEY platform."""
Expand Down Expand Up @@ -79,7 +94,7 @@ def upload_firmware(

try:
res = client.upload_firmware(
metadata, filename, sbom_path=sbom, enable_monitoring=False
metadata, filename, sbom_path=sbom, enable_monitoring=enable_monitoring, timeout=timeout
)
click.echo(res["id"])
except QueryError as e:
Expand Down