Fix:skip maximized fullscreen windows in bsp reconstruct #89 - #93
Merged
oliwebd merged 3 commits intoSep 10, 2026
Merged
Conversation
disable() destroys the tiling forest and every ShellWindow; enable() rebuilds the tree from live window rects and workspace ids. Two ways that's lossy across a lock/suspend cycle (#89): - Mutter can misreport a window's workspace after resume when a fullscreen window was active, so the rebuild bakes the wrong workspace into the tree. - A maximized window's live rect is full-screen, which distorts the BSP reconstruction for other windows on the same workspace and drops the maximize when the tree is retiled. Snapshot each tiled window's workspace and maximized state (keyed by stable_sequence, which survives the forest/entity teardown) on disable(), unmaximize before teardown so reconstruction reads the real tiled rect, then on enable() restore the workspace before auto_tile_on() runs and re-maximize once the rebuilt tree settles.
Their rect spans the full work area, overlaps every sibling, and breaks the BSP split-search in reconstruct.ts, which then force-retiles the whole [monitor, workspace] group (log: "no clean split found... falling back to sequential tiling"). on_maximize() already detaches these windows and reflows siblings to fill the gap, re-attaching on unmaximize — skipping them here just lets reconstruction rely on that existing behavior instead of fighting it.
…le/enable" This reverts commit 2250852.
oliwebd
deleted the
fix/skip-maximized-fullscreen-windows-in-bsp-reconstruct
branch
September 12, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Their rect spans the full work area, overlaps every sibling, and breaks
the BSP split-search in reconstruct.ts, which then force-retiles the
whole [monitor, workspace] group (log: "no clean split found... falling
back to sequential tiling"). on_maximize() already detaches these
windows and reflows siblings to fill the gap, re-attaching on
unmaximize: skipping them here just lets reconstruction rely on that
existing behavior instead of fighting it.