Fix canvas tab shadow clipping - #129
Conversation
📝 WalkthroughWalkthroughThe board picker now reserves space for popup shadows in light themes. Nested frames and offsets prevent tab movement and control overlap. The interaction shape remains limited to the original picker bounds. The changelog records the fix. ChangesCanvas tab shadow spacing
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5619ebdaeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
Validation
Fixes #110
Note
Fix shadow clipping on canvas tab board picker pills
The board picker's
LazyHStackwas clipping pill drop shadows to a hard edge in light themes. The fix expands theScrollViewviewport by the shadow overflow amount, offsets it back, and clamps the outer layout to the original dimensions — making shadows fade naturally without shifting the tab row or overlapping top-right controls..contentShape(.interaction, Rectangle())is applied to restrict hit-testing to the visible row, so the extra padding area does not intercept canvas gestures.Macroscope summarized cc6a007.
Summary
swiftc -parseandgit diff --check.