fix(skills): author display labels for every dictionary entry - #854
Open
qtjg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title
fix(skills): author display labels for every dictionary entry
PR body
Resolves #681
Summary
This change authors an explicit display label for every entry in the curated skill dictionary. Previously, 139 entries fell back to their lowercase canonical IDs, causing recognized skills such as
sql,postgresql,javascript, andiosto render with inconsistent casing beside authored and free-text labels.The dictionary now uses project-consistent brand casing, including
SQL,PostgreSQL,JavaScript,Node.js,GraphQL,iOS,jQuery,dbt, andgRPC. Aliases and canonical IDs are unchanged, so matching and deduplication behavior remain stable. The fallback ingetSkillIndex()remains as a defensive total-function guard, while a new test makes the authored-label invariant explicit.Changes
SKILLS_DICTIONARY_VERSIONfrom1.1to1.2and documented the data change.iOS,dbt,jQuery, andgRPC.SkillTermGuidancetests. Canonical skill IDs remain lowercase where the test is asserting identity rather than display text.Verification
npm run verifypasses: typecheck, lint, fixture-PII checks, core-package checks, 42 changed test files with 713 passing tests and 2 intentionally skipped tests, production build, and Fallow audit.npm test -- --run src/lib/job-search/query-builder.test.ts src/components/features/SkillTermGuidance.test.tsx src/lib/jd-match/extract-jd-terms.test.ts src/lib/jd-match/skills.test.tspasses: 109 tests.ghtoken is unavailable.