fix(skills): author display labels for all unlabelled dictionary entries (#681) - #853
Open
shubhransh-gupta wants to merge 1 commit into
Open
Conversation
11 tasks
Contributor
Author
|
@s-annam — review ping for #681 👋 CI is green (
Same pattern as the #607/#594 label work you merged before — happy to adjust any label spellings. Thanks! |
…ies (offlinecv#681) Every skill chip now renders branded casing (JavaScript, PostgreSQL, iOS) instead of lowercase kebab ids. Bumps SKILLS_DICTIONARY_VERSION to 1.2 and updates display-string test expectations; matching and aliases are unchanged.
shubhransh-gupta
force-pushed
the
fix/issue-681-skill-display-labels
branch
from
August 16, 2026 08:56
6bdfd97 to
2f3d3cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
labelvalues for all 139 previously-unlabelled entries injd-match/skills.ts, so recognized skills render asJavaScript,PostgreSQL,iOS, etc. instead of lowercase kebab ids.SKILLS_DICTIONARY_VERSIONto 1.2 and tightensskills.test.ts: explicit lowercase-brand allowlist (iOS,dbt,jQuery,gRPC,scikit-learn,pandas,pytest) plus a new invariant that every entry has an authored label.query-builder,extract-jd-terms,SkillTermGuidance). Matching, aliases, and id-based assertions are unchanged.Egress note (from #681)
query.skillsentries are sent verbatim to job feeds (tag=,search=). Casing changes frompython→Python; matching remains case-insensitive on our side.Test plan
npm run verifypasses locally (5875 tests)/jobs/skills row shows branded labels beside free-text chipsSkillTermGuidance"Already in your résumé" line uses labels, not idsFixes #681