[FIX] hr: change behavior of the new contract button for the payroll tab in employee - #5253
Open
aryep-odoo wants to merge 1 commit into
Open
Conversation
…tab in employee The button to create new contract that was in the employee's payroll ta was appearing even when no contract dates were selected, which was incorrect behavior. Is a problem because in order to create a contract you need both starting and closing dates. To avoid code duplication the solution was to target the fix in the 'ButtonNewContract' custom widget that is only used in those views in all places (community, enterprise and addons). Now, it is dynamically verified if the 'contract_date_start' exists before rendering the button. task-6519063
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-aryep, it needs to be retargeted before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button to create new contract that was in the employee's payroll ta was appearing even when no contract dates were selected, which was incorrect behavior.
Is a problem because in order to create a contract you need both starting and closing dates.
To avoid code duplication the solution was to target the fix in the 'ButtonNewContract' custom widget that is only used in those views in all places (community, enterprise and addons). Now, it is dynamically verified if the
'contract_date_start'exists before rendering the button.task-6519063