[FIX] hr_holidays: Time Type domain search crash when opening dropdow… - #5225
Open
sdemeesterde wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-samde, it needs to be retargeted before it can be merged. |
usseif97
requested changes
Aug 7, 2026
usseif97
left a comment
usseif97
left a comment
There was a problem hiding this comment.
Thanks for your work. The fix is to the point 🎯
Here's how bug-fix tasks are handled, and you got most of it 💪
But, also you should add a test to ensure that the issue doesn't reappear in the future and you should clearly add the test on the appropriate related test file
sdemeesterde
force-pushed
the
master-hr-onboarding-task_traceback_on_time_off_type-samde
branch
from
August 10, 2026 08:31
ec5f334 to
e93c0b4
Compare
…n btn Steps to reproduce the error: Prerequisite: - Have a Time off type (test_timeoff) with - "Requires allocation" ticked (= True) - "Allow Negative" not ticked (= False) - Create a regular allocation (Time Off > Management > Allocations > New) to an employee (test_employee) with - Time Type = test_timeoff - Allocation > 0 - Validate the allocation Bug error: - Navigate to Time Off > Time Types > Select any time type > Select smart button `Time off` > New - Select Employee = test_employee - Press Time Type -> ERROR Reason: The search method for virtual_remaining_leaves has a bug. The comparison function in _search_virtual_remaining_leaves accepts only one argument, when two are required. Solution: - Add the missing argument. - Add a unit test. Task: 6449756
sdemeesterde
force-pushed
the
master-hr-onboarding-task_traceback_on_time_off_type-samde
branch
from
August 10, 2026 08:46
e93c0b4 to
bf1fb3b
Compare
usseif97
reviewed
Aug 10, 2026
| 'number_of_days': 6, | ||
| }).action_approve() | ||
|
|
||
| domain = [ |
There was a problem hiding this comment.
No, need for the variable declaration, you can use it directly on the search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the error:
Prerequisite:
to an employee (test_employee) with
Bug error:
button
Time off> NewReason: The search method for virtual_remaining_leaves has a bug.
The comparison function in _search_virtual_remaining_leaves accepts only one argument,
when two are required.
Solution:
Task: 6449756