[CI] enable cache for Unix jobs - #5903
Conversation
9d089df to
d0c632d
Compare
5f8e2ac to
5bfe33b
Compare
c1d2a2b to
da16764
Compare
|
I tried to set |
da16764 to
f218c38
Compare
47e57c8 to
e711513
Compare
|
@Alizter disabling the dune cache for tests through |
|
@emillon The 8.16 makefile just calls dune under the hood so it shouldn't be an issue. We are generating the build rules ourselves since Dune is unable to generate and execute at the same time. AFAIK if DUNE_CACHE=enabled then it should work. Have a look at Makefile.dune. |
I understand that it's the intent, but this does not correspond to what is in the tarball that's being used by opam:
What confuses me is that in master, the Makefile just calls out to dune. But the version in the 8.16.0 release tarball does not have this so we're never going into Do you see what I mean? I don't know how the coq release process works in terms of branches and tags but the changes in the Makefile have not been propagated to the release tag. |
|
@emillon Sorry you are correct! It has been some time since I thought about it. I guess we have to wait one more version to take advantage of the Dune caching via opam. The changes Emilio and I made switching everything to Dune is in rocq-prover/rocq#15560 and that was tagged 8.17 rather than 8.16. The reason 8.16 released now is because the Summer got in the way. |
51804b1 to
f83e618
Compare
|
Makes sense! so 8.17 should use the dune cache out of the box. |
6db69c4 to
9bd398b
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com> ps-id: a9c15650-7c22-444a-a6cf-d8a6a56d830b Signed-off-by: Ali Caglayan <alizter@gmail.com>
9bd398b to
5c62118
Compare
No description provided.