test(pkg): show dune exec run binaries from project dependencies - #16310
Merged
Conversation
Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
3 tasks
punchagan
approved these changes
Sep 3, 2026
punchagan
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable. I've written a similar test as a part of my work for bin-narrowing in #15381. I wonder if it's better to eventually have my tests in the pkg/ directory instead of pkg/bin-narrowing. (I can fold my exec test into this one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I discovered this feature while working on #12914, and found that we currently don't have a test for it. This test essentially shows that it is currently possible to run a binary that is shipped with a dependency. I have examined more behaviors of this, which I'll try to add in follow-up PRs.
This is possible owing to:
dune/src/dune_rules/pkg_rules.ml
Lines 2571 to 2588 in 59105f8
Related Issue and Motivation
Relates to work to be done in #16185
Checklist