fix(env): give context env vars precedence over workspace vars - #16290
Merged
Conversation
3 tasks
Alizter
added a commit
that referenced
this pull request
Sep 1, 2026
To make the test easier to read and understand, `env/env-variables/precedence.t/` has been converted to a single file based test. This is a preparatory PR for #16290/ ## Checklist - [ ] ~Tests added, if applicable.~ - [ ] ~[Change log entry added](../CONTRIBUTING.md#updating-the-changelog) for any user-facing changes.~ - [ ] ~Documentation added for any user-facing changes.~
punchagan
force-pushed
the
fix-env-precedence
branch
from
September 1, 2026 11:41
9f63cb1 to
8fcb065
Compare
punchagan
changed the title
env vars defined in a (context ...) stanza are documented to have higher precedence than env vars defined in the root env stanza of a workspace. The prose in the cram test also indicates this, but the test asserted incorrect precedence. This seems to have been indicated in a review comment [here] and marked done, but may have been undone by an incorrect rebase or something. Only consumers of Super_context.context_env like `dune exec` were affected by this. Rules were not affected since they resolved their environment separately through `Env_node.external_env` which is not affected by this bug. [here]: ocaml#1147 (comment) Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
punchagan
force-pushed
the
fix-env-precedence
branch
from
September 1, 2026 11:44
8fcb065 to
65fc24a
Compare
punchagan
marked this pull request as ready for review
September 1, 2026 11:45
Alizter
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
env vars defined in a (context ...) stanza are documented to have higher
precedence than env vars defined in the root env stanza of a workspace.
The prose in the cram test also indicates this, but the test asserted
incorrect precedence. This seems to have been indicated in a review
comment here and marked done, but may have been undone by an incorrect
rebase or something.
Only consumers of Super_context.context_env like
dune execwereaffected by this. Rules were not affected since they resolved their
environment separately through
Env_node.external_envwhich is notaffected by this bug.
Related Issue and Motivation
This issue was discovered while working on #15381
Checklist