Add explicit return type to getSettingDefinitions() examples - #263
Open
sgreg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new plugin using obsidianmd/obsidian-sample-plugin@07ceb81 as template, and wanted to try out the new declarative settings.
However, copying the examples from the documentation as-is caused build errors
Type '{ type: string; key: string; defaultValue?: undefined; options?: undefined; placeholder?: undefined; validate?: undefined; }' is not assignable to type 'SettingFolderControl<string>'forgetSettingDefinitions().Declaring
SettingDefinitionItem[]explicitly asgetSettingDefinitions()'s return type solved it, so adding that to the migration and Settings examples.