Show device-inactive state as a sidebar banner instead of an overlay - #261
Open
r2evans wants to merge 1 commit into
Open
Show device-inactive state as a sidebar banner instead of an overlay#261r2evans wants to merge 1 commit into
r2evans wants to merge 1 commit into
Conversation
When the active R graphics device is switched away from httpgd (e.g. opening a pdf device), the client covered the entire page with a "Device inactive." overlay. That blocked all interaction with the page even though everything still works while the device is inactive: browsing the plot history, zooming, exporting. Replace the overlay with a compact "Device inactive" banner pinned above the plot history sidebar. It appears when the device becomes inactive and disappears on its own when the device is active again, driven by the existing reactive deviceActive state. The full-screen overlay remains for the "Connection lost" case, where the page truly cannot do anything. Closes nx10#233 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the active R graphics device is switched away from httpgd (e.g. opening a pdf device), the client covered the entire page with a "Device inactive." overlay. That blocked all interaction with the page even though everything still works while the device is inactive: browsing the plot history, zooming, exporting.
Replace the overlay with a compact "Device inactive" banner pinned above the plot history sidebar. It appears when the device becomes inactive and disappears on its own when the device is active again, driven by the existing reactive deviceActive state. The full-screen overlay remains for the "Connection lost" case, where the page truly cannot do anything.
Closes #233
This is useful to me because I often want multiple plots for the same R process and be able to compare them side-by-side. When the whole screen has a blocker "Device inactive", I cannot see what is under the obscuring layer.