Skip to content

Bump elide-runtime; adapt PolicyDraft to restructured PolicyDefinition - #234

Merged
martsokha merged 1 commit into
mainfrom
chore/bump-runtime-1623ee3
Aug 15, 2026
Merged

Bump elide-runtime; adapt PolicyDraft to restructured PolicyDefinition#234
martsokha merged 1 commit into
mainfrom
chore/bump-runtime-1623ee3

Conversation

@martsokha

@martsokha martsokha commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

Bump elide-runtime 1786c1a1623ee3 (elide df3d7083ac996a — the pair the runtime commit pins).

Breaking change adapted

The bump restructured PolicyDefinition's recognition vocabulary:

  • labels: Labels + groups: Vec<LabelGroup>scopes: Vec<LabelScope> + custom: Vec<Label>
  • Labels and LabelGroup removed.

Updated the PolicyDraft request DTO (and its into_definition) to the new field model, reusing the engine types — LabelScope from elide_pipeline::policy, Label from elide_pipeline::entity. Server-owned id/template handling is unchanged (still stamped server-side, still absent from the request schema).

No new dependencies (both types reachable through elide-pipeline; cargo machete clean).

Frontend note

PolicyDraft / PolicyDefinition change shape on the wire: labels/groupsscopes/custom. The frontend should regenerate its client off the updated OpenAPI and migrate any policy-authoring UI accordingly.

Testing

Full gate green: cargo check, cargo clippy -D warnings, cargo machete, RUSTDOCFLAGS=-D warnings cargo doc, and the full cargo test suite.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Updated policy configuration to support label scopes and custom labels.
  • Changes

    • Policy definitions now use the revised label configuration format for improved flexibility.

Bump elide-runtime 1786c1a -> 1623ee3 (elide df3d708 -> 3ac996a, the pair the
runtime commit pins).

The bump restructured PolicyDefinition's recognition vocabulary: `labels: Labels`
+ `groups: Vec<LabelGroup>` became `scopes: Vec<LabelScope>` + `custom: Vec<Label>`
(Labels and LabelGroup removed). Update the PolicyDraft request DTO and its
into_definition to the new fields, reusing the engine types (LabelScope from
elide_pipeline::policy, Label from elide_pipeline::entity). Server-owned
id/template handling is unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@martsokha martsokha added chore maintenance, dependency updates, code cleanup server API handlers, middleware, auth dependencies dependency updates and version bumps labels Aug 15, 2026
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d543171-e023-4280-8584-a77a9b6e307d

📥 Commits

Reviewing files that changed from the base of the PR and between 1d0dcd6 and ef2dd73.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/nvisy-server/src/handler/request/policies.rs

Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

PolicyDraft replaces its label and group fields with scoped and custom label fields. The conversion to PolicyDefinition now transfers these fields.

Changes

Policy label configuration

Layer / File(s) Summary
Update PolicyDraft label mapping
crates/nvisy-server/src/handler/request/policies.rs
PolicyDraft now uses scopes: Vec<LabelScope> and custom: Vec<Label>. into_definition transfers both fields to PolicyDefinition.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to ef2dd

This changes policy requests from labels/groups to scopes/custom; clients that have not migrated may create policies with empty recognition values. The PR is mergeable with explicit owner follow-up to verify and update external clients.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both the runtime update and the PolicyDraft adaptation, which are the main changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-runtime-1623ee3

Comment @coderabbitai help to get the list of available commands.

@martsokha martsokha self-assigned this Aug 15, 2026
@martsokha
martsokha merged commit ca63e7c into main Aug 15, 2026
9 checks passed
@martsokha
martsokha deleted the chore/bump-runtime-1623ee3 branch August 15, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore maintenance, dependency updates, code cleanup dependencies dependency updates and version bumps server API handlers, middleware, auth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant