Bump elide-runtime; adapt PolicyDraft to restructured PolicyDefinition - #234
Conversation
Bump elide-runtime 1786c1a -> 1623ee3 (elide df3d708 -> 3ac996a, the pair the runtime commit pins). The bump restructured PolicyDefinition's recognition vocabulary: `labels: Labels` + `groups: Vec<LabelGroup>` became `scopes: Vec<LabelScope>` + `custom: Vec<Label>` (Labels and LabelGroup removed). Update the PolicyDraft request DTO and its into_definition to the new fields, reusing the engine types (LabelScope from elide_pipeline::policy, Label from elide_pipeline::entity). Server-owned id/template handling is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesPolicy label configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to This changes policy requests from labels/groups to scopes/custom; clients that have not migrated may create policies with empty recognition values. The PR is mergeable with explicit owner follow-up to verify and update external clients. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Bump
elide-runtime1786c1a→1623ee3(elidedf3d708→3ac996a— the pair the runtime commit pins).Breaking change adapted
The bump restructured
PolicyDefinition's recognition vocabulary:labels: Labels+groups: Vec<LabelGroup>→scopes: Vec<LabelScope>+custom: Vec<Label>LabelsandLabelGroupremoved.Updated the
PolicyDraftrequest DTO (and itsinto_definition) to the new field model, reusing the engine types —LabelScopefromelide_pipeline::policy,Labelfromelide_pipeline::entity. Server-ownedid/templatehandling is unchanged (still stamped server-side, still absent from the request schema).No new dependencies (both types reachable through
elide-pipeline;cargo macheteclean).Frontend note
PolicyDraft/PolicyDefinitionchange shape on the wire:labels/groups→scopes/custom. The frontend should regenerate its client off the updated OpenAPI and migrate any policy-authoring UI accordingly.Testing
Full gate green:
cargo check,cargo clippy -D warnings,cargo machete,RUSTDOCFLAGS=-D warnings cargo doc, and the fullcargo testsuite.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Changes