Fix braille dimension warnings in NVDA 2026.2 - #84
Closed
kazek5p-git wants to merge 2 commits into
Closed
Conversation
kazek5p-git
force-pushed
the
fix-nvda-2026-2-braille-dimensions
branch
from
August 8, 2026 17:47
f3c2685 to
8592316
Compare
kazek5p-git
changed the title
Member
|
In NVDA 2026.2, there is no braille.display module. There are no deprecation warnings printed to the log, and main thread is not blocked. In addition, this change does not ensure backwards compatibility between 2025.x and 2026.2, where braille.DisplayDimensions is expected and is also the recommended method. If this pr is merged, it introduces bugs and may break the add-on. Described testing procedure is completely useless. If you want to continue using artificial intelligence, please don't contribute to this project. AI pull requests without an expert developer behind aren't welcome here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In NVDA 2026.2,
braille.DisplayDimensionsis deprecated and each use logs a warning with a full traceback. When a remote control connection is established, the TeleNVDA callback is invoked repeatedly, causing the log to grow rapidly and temporarily blocking NVDA's main thread.Change
The callback now imports
DisplayDimensionsfrombraille.display, the current NVDA API. Behavior is unchanged; the callback is registered only for NVDA 2025 and newer.Verification
python -m py_compile addon/globalPlugins/remoteClient/local_machine.pygit diff --check