feat: add more info in templates - #1774
Conversation
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMultiple template JSON manifests now include explicit Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
danielroe
changed the title
e9fb953 to
b287d45
Compare
| @@ -1,7 +1,10 @@ | |||
| { | |||
| "name": "layer", | |||
| "deprecated": true, | |||
There was a problem hiding this comment.
Why is layer deprecated? 🤔
There was a problem hiding this comment.
Since the idea was to generate a new API shared by both nuxt.new and the CLI, I have harmonized the deprecated status with this hidden attribute: https://github.com/nuxt/cli/blob/main/packages/nuxi/src/utils/starter-templates.ts#L4
| @@ -1,7 +1,10 @@ | |||
| { | |||
| "name": "ui-vue", | |||
| "deprecated": true, | |||
There was a problem hiding this comment.
This starter is still working!
There was a problem hiding this comment.
Since the idea was to generate a new API shared by both nuxt.new and the CLI, I have harmonized the deprecated status with this hidden attribute: https://github.com/nuxt/cli/blob/main/packages/nuxi/src/utils/starter-templates.ts#L4
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@template.schema.json`:
- Line 7: Make the source metadata contract explicit: in template.schema.json:7
require repo and branch alongside name and tar, and in
template.schema.json:50-57 add validation or CI checking that these fields match
the tarball coordinates. In templates/v5-nightly.json:2-7 add repo
"nuxt/starter" and branch "v5-nightly" to match nuxt/starter:v5-nightly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5eb154c1-9828-4d73-b549-f15dda252032
📒 Files selected for processing (26)
template.schema.jsontemplates/community/sidebase.jsontemplates/content.jsontemplates/doc-driven.jsontemplates/hub.jsontemplates/layer.jsontemplates/minimal.jsontemplates/module-devtools.jsontemplates/module.jsontemplates/ui-vue.jsontemplates/ui-vue/chat.jsontemplates/ui-vue/dashboard.jsontemplates/ui.jsontemplates/ui/changelog.jsontemplates/ui/chat.jsontemplates/ui/dashboard.jsontemplates/ui/docs.jsontemplates/ui/editor.jsontemplates/ui/landing.jsontemplates/ui/portfolio.jsontemplates/ui/saas.jsontemplates/v2-bridge.jsontemplates/v3.jsontemplates/v4-compat.jsontemplates/v4.jsontemplates/v5-nightly.json
🚧 Files skipped from review as they are similar to previous changes (18)
- templates/ui/editor.json
- templates/layer.json
- templates/ui/dashboard.json
- templates/v2-bridge.json
- templates/ui-vue/chat.json
- templates/v4.json
- templates/ui/landing.json
- templates/hub.json
- templates/module-devtools.json
- templates/ui-vue/dashboard.json
- templates/ui/portfolio.json
- templates/v4-compat.json
- templates/ui-vue.json
- templates/doc-driven.json
- templates/ui/changelog.json
- templates/v3.json
- templates/ui/saas.json
- templates/minimal.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/validate-templates.mjs`:
- Around line 20-45: Update the validation flow in
scripts/validate-templates.mjs to reject a null or non-object parsed template
before iterating its keys, reporting it through fail instead of crashing. Also
enforce each schema.properties entry’s declared type, including top-level
schema.type, and call fail with a clear key/value type error when a value such
as string "false" violates the schema; preserve the existing required-key and
pattern checks for valid objects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b9425612-3a64-4c43-a435-4716014be738
📒 Files selected for processing (5)
.github/workflows/validate-templates.ymlscripts/validate-templates.mjstemplate.schema.jsontemplates/community/sidebase.jsontemplates/v5-nightly.json
🚧 Files skipped from review as they are similar to previous changes (2)
- template.schema.json
- templates/community/sidebase.json
3 participants
🔗 Linked issue
nuxt/nuxt.new#492
❓ Type of change
📚 Description