Fix export service error with the new timetable config schema - #4277
Merged
leslieyip02 merged 2 commits intoJan 1, 2026
Conversation
Updated the validation logic in the export service
|
@zehata is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4277 +/- ##
==========================================
+ Coverage 54.52% 56.78% +2.26%
==========================================
Files 274 297 +23
Lines 6076 6924 +848
Branches 1455 1671 +216
==========================================
+ Hits 3313 3932 +619
- Misses 2763 2992 +229 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Yeah the export service is quite old and the testing issue was raised in #3926. We should probably do something about it. |
Member
|
For future reference, we missed 3 issues:
Fixed by these commits: (this is pretty sloppy but I just wanted to get it fixed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the validation logic in the export service
Context
Resolves https://t.me/NUSMods/13264
This was caused by the validation logic in
nusmods/export/src/data.ts
Lines 64 to 71 in f722758
The systemic problem is that there is currently no test coverage for the export service. It also took a long time to fix because the readme is really outdated.
Other Information
Sample image and pdf output of the export service, showing no regression from before #4225:

My Timetable.pdf