refactor(optimiser): Enhance module slot merging and filtering logic - #4251
Conversation
- Introduced sorting of module slots by Day and StartTime to ensure consistent combination keys. - Updated the combination key generation to handle cases with non-E-Venues, preventing duplicates. - Improved parsing of module slot fields before processing to handle invalid slots more effectively.
|
@thejus03 is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4251 +/- ##
==========================================
+ Coverage 54.52% 55.13% +0.60%
==========================================
Files 274 297 +23
Lines 6076 6724 +648
Branches 1455 1617 +162
==========================================
+ Hits 3313 3707 +394
- Misses 2763 3017 +254 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sorry, was busy with something else, let me try this out locally. |
|
@thejus03 Thanks for the PR, I have tried it locally, it fixed the issue relating to collision, and I have found that it has no conflict with #4225 and has also fixed the issue with some slots not being serialized, so it looks good to me 👍 cc: @leslieyip02 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 participants
Context
Fixes #4249
Implementation
Explained in some detail in #4250