chore: retire strategy vocabulary and banners in modules#628
Merged
Conversation
Rename the modules' pure-logic files off the stale strategy name: ethflow-watcher submits observations to venues so its logic is keeper.rs, while the read-only balance-tracker, http-probe and price-alert examples become logic.rs. Update every mod declaration, path reference, module.toml and Cargo.toml comment to match. De-stale the word strategy in module comments and doc comments to keeper (ethflow-watcher, twap-monitor) or module (generic), and kill the banner divider comments throughout modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the modules' pure-logic files off the stale
strategyname and repoint every reference:ethflow-watcher/src/strategy.rsbecomeskeeper.rs(it submits observations to venues), while the read-onlybalance-tracker,http-probeandprice-alertexamples becomelogic.rs. De-stale the wordstrategyin module comments and doc comments tokeeper(keeper modules) ormodule(generic), and kill the banner divider comments throughoutmodules/**.Why
The
strategyname predates the keeper/module vocabulary and no longer matches how these guests are described; banner comments are noise the house style drops. Comments, filenames and mod references only, no behaviour change.Testing
nix develop --command just ciplusjust check-venue-agnosticandjust check-cow-orderbook-only, all green (the rename compiles the module wasms).AI Assistance
Drafted with AI assistance.
Part of #625