chore: retire strategy vocabulary and banners in crates#627
Merged
Conversation
De-stale the word "strategy" in crate comments and doc comments to "keeper" (a keeper submits to venues) or "module" (the generic guest) as fits each context, leaving the proptest crate's own `Strategy` trait in nexum-sdk/src/proptests.rs untouched. Kill banner/section-divider line comments throughout crates/**, including test modules, per the umbrella hygiene sweep. Part of #625.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
De-stale the word "strategy" in
crates/**comments and doc comments, retiring it to "keeper" (a keeper submits to venues) or "module" (the generic guest) as each context fits, and delete banner/section-divider line comments throughoutcrates/**, including test modules.Why
Part of the umbrella hygiene sweep (#625): the "strategy" name is stale project vocabulary, and banner comments add noise without structure that the type and module layout does not already carry.
Testing
nix develop --command just ci(rustfmt, clippy-D warnings, rustdoc, module wasm builds, full workspace test suite) plusjust check-venue-agnosticandjust check-cow-orderbook-only, all green.Split candidates
crates/videre-test/src/transport.rswas the only non-test src file whose banner separated a genuine domain: an// httpdivider fenced off the outbound-HTTP mock (MockFetch,RecordedRequest,StoredResponse,host_allowed) from the composedMockTransport. Noted only, not split here.AI Assistance
Drafted with Claude Code under human review.
Part of #625.