feat(freebsd): select inotify on 14.5+ - #989
Merged
Merged
Conversation
Native inotify ships in FreeBSD 14.5, so auto-select by major.minor instead of treating only 15.0+ as supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #972: native inotify ships in FreeBSD 14.5 (syscalls and libc wrappers) thanks to @markjdb, not only 15.0+.
Autoselect now compares
freebsd-version -uas(major, minor) >= (14, 5)so native builds on 14.5+ use inotify and older 14.x stays on kqueue. Thefreebsd_inotifyfeature still forces inotify for cross-compiles targeting 14.5+.CI is unchanged: 14.4 covers kqueue, 15.1 covers inotify as it will be some time before the 14.4 builder ages out and the coverage testing is still useful.
Related Issues