fix: address comprehensive code review findings - #23
Merged
Conversation
Harden verify output purity, fix render/diff edge cases, and clean up repo hygiene: - verify --verbose now routes the introspection block to stderr for every non-human format (github/junit included), keeping machine-readable stdout parseable - add Trae to the --help ecosystem list and correct the README target count (18 -> 19) - gitignore and remove committed agent-benchmark result artifacts (they contained machine-specific absolute paths), delete a stray `=` dir, and extend the CI package-content guard to block both - dedupe ensure_no_symlink_ancestors into generate.rs, shared by init/update/--fix so the symlink-escape hardening can't drift - time-box the verify_stdin write in spawn.rs (a child that never reads stdin can no longer hang the probe past HELP_TIMEOUT); regression test - diff reports trailing-newline-only drift instead of "(no lines differ)" - verify --fix suggestions point at skillpack.toml for config-driven checks (when_to_use/allowed_tools/plugin fields) so users don't loop on a no-op - escape tabs in YAML descriptions and quotes/backslashes in glob lists; --target list honors --format json; strict is_json(); widen the watch noise filter; fix the misleading Shell/Powershell detection comment 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: address comprehensive code review findings
Harden verify output purity, fix render/diff edge cases, and clean up
repo hygiene:
non-human format (github/junit included), keeping machine-readable stdout
parseable
(18 -> 19)
contained machine-specific absolute paths), delete a stray
=dir, andextend the CI package-content guard to block both
init/update/--fix so the symlink-escape hardening can't drift
stdin can no longer hang the probe past HELP_TIMEOUT); regression test
(when_to_use/allowed_tools/plugin fields) so users don't loop on a no-op
--target list honors --format json; strict is_json(); widen the watch
noise filter; fix the misleading Shell/Powershell detection comment