fix(interop): preserve typed-array backing slices - #821
Open
nnunley wants to merge 1 commit into
Open
Conversation
mparrett
approved these changes
Sep 7, 2026
mparrett
left a comment
Collaborator
There was a problem hiding this comment.
No actionable findings. The compatible-slice fast path preserves TypedArray backing identity while retaining the existing conversion path for fixed arrays, incompatible element types, and persistent collections. Focused VM/API/language tests, race tests, vet, and generated-artifact validation pass; CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypedArraybacking slices at the Go reflection boundaryio.Reader.Readat the language level and verify caller-visible bytesVerification
go vet ./pkg/vm ./pkg/api ./testgo test ./pkg/vm ./pkg/api./testtests outside the fixture runnermake generatemake check-generatedThe full local fixture runner was also attempted: 810 tests passed and 10 fixture cases failed only because this sandbox denies writes to literal
/tmppaths. The exact #813 regression passes.Fixes #813