feat: streamline nominal ingest skill - #8
Open
Leundai wants to merge 4 commits into
Open
Conversation
Leundai
marked this pull request as ready for review
August 5, 2026 17:34
Leundai
enabled auto-merge
August 5, 2026 17:57
Leundai
disabled auto-merge
August 5, 2026 17:57
Leundai
enabled auto-merge (squash)
August 5, 2026 17:57
gjkeller-nmnl
suggested changes
Aug 5, 2026
gjkeller-nmnl
left a comment
There was a problem hiding this comment.
Fearful of -400 lines and only +200 lines, big regression potential
gjkeller-nmnl
left a comment
There was a problem hiding this comment.
Fearful of -400 lines and only +200 lines, big regression potential
(removing my 'request changes') will defer to @alkasm and @tarun-prakash-nmnl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the Nominal ingest skill through progressive disclosure: the main workflow keeps the approval and safety gates, while branch-specific detail loads only when it applies.
The execution, recovery, and command guidance remains available for the write path, so the refactor does not narrow supported ingest behavior.
What changed and testing
What changed
Testing plan
uv run scripts/validate_skills.py