Skip to content

feat: streamline nominal ingest skill - #8

Open
Leundai wants to merge 4 commits into
mainfrom
agent/streamline-ingest-skill
Open

feat: streamline nominal ingest skill#8
Leundai wants to merge 4 commits into
mainfrom
agent/streamline-ingest-skill

Conversation

@Leundai

@Leundai Leundai commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Streamlines the Nominal ingest skill through progressive disclosure: the main workflow keeps the approval and safety gates, while branch-specific detail loads only when it applies.

The execution, recovery, and command guidance remains available for the write path, so the refactor does not narrow supported ingest behavior.

What changed and testing

What changed

  • Add focused references for profile setup, file inspection, plans, and execution.
  • Preserve exact command patterns, ownership rules, failure boundaries, recovery steps, and validation guidance in the relevant references.
  • Keep raw endpoint operations outside the skill and require explicit approval before any write.

Testing plan

  • uv run scripts/validate_skills.py

@Leundai
Leundai marked this pull request as ready for review August 5, 2026 17:34

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread skills/nominal-ingest/references/authentication.md Outdated
Comment thread skills/nominal-ingest/SKILL.md Outdated
@Leundai
Leundai enabled auto-merge August 5, 2026 17:57
@Leundai
Leundai disabled auto-merge August 5, 2026 17:57
@Leundai
Leundai enabled auto-merge (squash) August 5, 2026 17:57

@gjkeller-nmnl gjkeller-nmnl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fearful of -400 lines and only +200 lines, big regression potential

@Leundai Leundai changed the title feat: streamline nominal ingest skill fix: clarify nominal profile API host Aug 5, 2026
@Leundai Leundai changed the title fix: clarify nominal profile API host feat: streamline nominal ingest skill Aug 5, 2026

@gjkeller-nmnl gjkeller-nmnl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fearful of -400 lines and only +200 lines, big regression potential
(removing my 'request changes') will defer to @alkasm and @tarun-prakash-nmnl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants