process: add process.entrypoint - #64800
Open
avivkeller wants to merge 2 commits into
Open
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
Collaborator
|
Review requested:
|
Member
Author
|
@nodejs/process |
Member
|
in worker threadsx this is set to the entrypoint of the worker? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64800 +/- ##
==========================================
- Coverage 90.16% 90.12% -0.05%
==========================================
Files 744 744
Lines 242518 242571 +53
Branches 45705 45695 -10
==========================================
- Hits 218670 218615 -55
- Misses 15357 15443 +86
- Partials 8491 8513 +22
🚀 New features to boost your workflow:
|
Member
Author
This is set to the entrypoint of the process that created the worker, not the worker itself. So if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51840
Adds a
process.entrypointnon-configurable property to theprocessobject during bootstrap. This property reflects the executable's main entrypoint (i.e. not--requireor--import-ed files, the main file).Additionally, this entrypoint is passed to workers, so it reflects the entrypoint of the process that created the worker, not the entrypoint of the worker itself.