stream: preserve push signal abort reason - #64798
Open
trivikr wants to merge 1 commit into
Open
Conversation
Pass the stream-wide signal reason directly to writer.fail() so valid non-Error abort reasons are not replaced with an AbortError. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
avivkeller
approved these changes
Jul 28, 2026
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64798 +/- ##
==========================================
- Coverage 90.16% 90.12% -0.04%
==========================================
Files 744 744
Lines 242518 242516 -2
Branches 45705 45695 -10
==========================================
- Hits 218670 218574 -96
- Misses 15357 15443 +86
- Partials 8491 8499 +8
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64797
The push stream's stream-wide abort handler only forwarded the signal's
reason when it was an
Error. Valid non-Error reasons, such as strings andnumbers, were replaced with a new
AbortError.Pass
signal.reasondirectly towriter.fail()so the writer fails with theoriginal reason.
Assisted-by: codex:gpt-5.6-sol