net: runtime-deprecate Server.prototype._listen2 - #64794
Open
araujogui wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
net-deprecate-listen2
branch
from
July 28, 2026 00:54
ef74dda to
162e6e6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64794 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.02%
==========================================
Files 744 744
Lines 242518 242537 +19
Branches 45705 45690 -15
==========================================
- Hits 218670 218640 -30
- Misses 15357 15381 +24
- Partials 8491 8516 +25
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 28, 2026
pimterry
approved these changes
Jul 28, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
| function that sets up the listening handle. It is kept only so that code | ||
| replacing it keeps being called by [`server.listen()`][], and it will be | ||
| removed in a future version of Node.js. Use [`server.listen()`][] instead of | ||
| calling or overriding `_listen2`. |
Member
There was a problem hiding this comment.
can we have before/after example ?
bmuenzenmeyer
approved these changes
Jul 28, 2026
bjohansebas
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64666