url: fix URLPattern USVString coercion - #64786
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Archkon
force-pushed
the
url5
branch
3 times, most recently
from
July 27, 2026 16:57
faaedd7 to
2ec6cde
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64786 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.02%
==========================================
Files 744 744
Lines 242518 242489 -29
Branches 45705 45679 -26
==========================================
- Hits 218670 218603 -67
- Misses 15357 15398 +41
+ Partials 8491 8488 -3
🚀 New features to boost your workflow:
|
Apply WebIDL USVString conversion after resolving URLPattern overloads and union branches. Coerce primitive URLPatternInput values through the string branch and coerce baseURL values in the constructor, exec(), and test(). Keep objects on the URLPatternInit or options dictionary branches where required, and propagate conversion exceptions unchanged. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64785