Skip to content

fs: fix out-of-bounds write in mkdtemp for long prefixes #64770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frandle331-yh wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fs: fix out-of-bounds write in mkdtemp for long prefixes #64770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3364,10 +3364,11 @@ static void Mkdtemp(const FunctionCallbackInfo<Value>& args) {
CHECK_GE(argc, 2);

BufferValue tmpl(isolate, args[0]);
static constexpr const char* const suffix = "XXXXXX";
const auto length = tmpl.length();
tmpl.AllocateSufficientStorage(length + strlen(suffix));
snprintf(tmpl.out() + length, tmpl.length(), "%s", suffix);
const auto prefix_length = tmpl.length();
static constexpr std::string_view suffix = "XXXXXX";
tmpl.AllocateSufficientStorage(prefix_length + suffix.size() + 1);
memcpy(tmpl.out() + prefix_length, suffix.data(), suffix.size());
tmpl.SetLengthAndZeroTerminate(prefix_length + suffix.size());

CHECK_NOT_NULL(*tmpl);

Expand Down
Loading