stream: use validateString for consumer encoding - #64754
Open
sjungwon03 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
sjungwon03
marked this pull request as ready for review
July 26, 2026 09:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64754 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 744 744
Lines 242517 242539 +22
Branches 45688 45690 +2
=======================================
+ Hits 218642 218671 +29
- Misses 15358 15368 +10
+ Partials 8517 8500 -17
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Jul 26, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Replace the manual `options.encoding` type check in stream iterator consumers with the shared validator. Add coverage for non-string values in the async and sync text consumers. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03
force-pushed
the
stream/use-validate-string-consumer-encoding
branch
from
July 28, 2026 14:04
4913e0f to
396f764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the manual
options.encodingtype check in stream iteratorconsumers with the shared
validateString()validator.This preserves the existing error behavior while using the common validation
helper. It also adds coverage for non-string
encodingvalues in both theasync
text()and synctextSync()consumers.