Skip to content

doc: stabilize --disable-warning - #64742

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
jean-michelet:docs/stabilize-disable-warning
Jul 28, 2026
Merged

doc: stabilize --disable-warning#64742
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
jean-michelet:docs/stabilize-disable-warning

Conversation

@jean-michelet

Copy link
Copy Markdown
Contributor

Mark --disable-warning=code-or-type as Stability: 2 - Stable

This supports fastify/fastify#6871, we would like to inform Fastify users that they can silence specific warnings. Before recommending that option, I would prefer its documented behavior to be considered stable.

The option has been available since Node.js 21.3.0 and was backported in #51124. Its behavior is covered by existing tests.

If further work is needed, I’m happy to add it in another commit.

Signed-off-by: Jean <jean.antoine.michelet@gmail.com>
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jul 25, 2026
Comment thread doc/api/cli.md
Comment thread doc/api/cli.md
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Comment thread doc/api/cli.md Outdated
Co-authored-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64742
✔  Done loading data for nodejs/node/pull/64742
----------------------------------- PR info ------------------------------------
Title      doc: stabilize --disable-warning (#64742)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jean-michelet:docs/stabilize-disable-warning -> nodejs:main
Labels     doc, cli, author ready
Commits    3
 - doc: stabilize --disable-warning
 - Update doc/api/cli.md
 - docs: fix English mistake
Committers 2
 - Jean <jean.antoine.michelet@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64742
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64742
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 25 Jul 2026 19:56:30 GMT
   ✔  Approvals: 2
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64742#pullrequestreview-4781130134
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64742#pullrequestreview-4782447363
   ✘  4 GitHub CI job(s) failed:
   ✘    - build-docs: FAILURE (https://github.com/nodejs/node/actions/runs/30199250940/job/89833742798)
   ✘    - lint-js-and-md: FAILURE (https://github.com/nodejs/node/actions/runs/30199250969/job/89833743204)
   ✘    - test-linux (ubuntu-24.04): FAILURE (https://github.com/nodejs/node/actions/runs/30199250976/job/89833743479)
   ✘    - test-linux (ubuntu-24.04-arm): FAILURE (https://github.com/nodejs/node/actions/runs/30199250976/job/89833743484)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/30302385912

@Renegade334 Renegade334 removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 28, 2026
@Renegade334

Copy link
Copy Markdown
Member

CI failures are relevant.

Comment thread doc/api/cli.md Outdated
@Renegade334 Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 28, 2026
@Renegade334
Renegade334 force-pushed the docs/stabilize-disable-warning branch from 4303202 to eeb2995 Compare July 28, 2026 04:14
@Renegade334
Renegade334 requested a review from avivkeller July 28, 2026 04:14
@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 853039c into nodejs:main Jul 28, 2026
18 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 853039c

@jean-michelet
jean-michelet deleted the docs/stabilize-disable-warning branch July 28, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issues and PRs related to the Node.js command line interface. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants