url: create URLPattern result properties in WebIDL order - #64733
Merged
Conversation
Contributor
Author
|
ping @nodejs/url |
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64733 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 744 744
Lines 242517 242517
Branches 45688 45696 +8
==========================================
- Hits 218642 218620 -22
- Misses 15358 15386 +28
+ Partials 8517 8511 -6
🚀 New features to boost your workflow:
|
Reorder the URLPatternResult and URLPatternComponentResult dictionary templates, together with their value arrays, to follow the lexicographical member order required by WebIDL. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
anonrig
approved these changes
Jul 26, 2026
Contributor
Author
|
Could some collaborator apply request-ci for this ? |
anonrig
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Jul 27, 2026
Contributor
Author
Member
failures are unrelated, we'll resume CI once the build infra issue gets resolved |
Collaborator
Contributor
Author
|
@panva Could you consider this pr to be added to commit queue and I maybe need to work on this commit to push other pr that related to whatwg-url forward?Many thanks! |
panva
added
the
commit-queue
Member
|
@Archkon thank you for working on this! |
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b4bbb12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64732