Skip to content

build: run perfetto build and test on GHA - #64721

Open
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:ci-perfetto
Open

build: run perfetto build and test on GHA#64721
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:ci-perfetto

Conversation

@legendecas

@legendecas legendecas commented Jul 24, 2026

Copy link
Copy Markdown
Member

This ensures that the src/lib changes (like emitting trace events) are compatible with perfetto, and compatible with V8 compiled with perfetto.

Refs: #64565
Fixes: nodejs/diagnostics#654

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 24, 2026
@legendecas legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jul 24, 2026
Comment on lines +44 to +48
path: node
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./node/.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path: node
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./node/.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: .github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

nit: use the CWD

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .github/workflows/test-linux-perfetto.yml Outdated
Comment thread .github/workflows/test-linux-perfetto.yml Outdated
Comment thread .github/workflows/test-linux-perfetto.yml Outdated

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably update the other workflows to use the CWD, IMO it's cleaner

@Renegade334

Copy link
Copy Markdown
Member

Could we enable this for the existing Linux workflow rather than adding an additional run?

@Renegade334
Renegade334 requested a review from aduh95 July 25, 2026 02:09
@legendecas

Copy link
Copy Markdown
Member Author

Could we enable this for the existing Linux workflow rather than adding an additional run?

We could. Still, I think in the near future, we might want to keep testing both legacy tracing and perfetto tracing, until we can fully deprecate the legacy one.

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other flags (except QUIC, but the QUIC job being restricted to a very limited set of files, that's less of a concern), we put this as part of the test-shared workflow. Can we do that here as well? Having a dedicated job is probably a waste and won't scale well.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (9041ad0) to head (f49f214).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64721      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.02%     
==========================================
  Files         743      744       +1     
  Lines      242324   242518     +194     
  Branches    45629    45689      +60     
==========================================
+ Hits       218396   218624     +228     
+ Misses      15440    15391      -49     
- Partials     8488     8503      +15     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reopening Perfetto in Node discussion

6 participants