http: avoid aborting IncomingMessage signal on normal close by Archkon · Pull Request #64392 · nodejs/node

Archkon · 2026-07-09T14:25:31Z

nodejs-github-bot · 2026-07-09T14:25:37Z

Review requested:

@nodejs/http
@nodejs/net

codecov · 2026-07-09T17:29:23Z

Codecov Report

❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (58795e9) to head (2ced6a6).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/_http_incoming.js	85.18%	7 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64392      +/-   ##
==========================================
- Coverage   90.16%   90.13%   -0.03%     
==========================================
  Files         744      744              
  Lines      242518   242575      +57     
  Branches    45692    45702      +10     
==========================================
- Hits       218663   218642      -21     
- Misses      15349    15445      +96     
+ Partials     8506     8488      -18

Files with missing lines	Coverage Δ
lib/_http_client.js	`97.63% <100.00%> (+<0.01%)`	⬆️
lib/_http_server.js	`96.51% <100.00%> (-0.13%)`	⬇️
lib/_http_incoming.js	`97.91% <85.18%> (-1.46%)`	⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Ethan-Arrowood

http.md:3052 says the signal "is aborted when the underlying socket closes or the request is destroyed." After this PR, neither is unconditionally true: normal completion detaches the socket listener, and destroy-after-completion no longer aborts. The PR touches no docs. It needs the prose rewritten (something like "aborted when the client disconnects before the message completes") plus a changes:/REPLACEME YAML entry.

Archkon · 2026-07-14T08:53:32Z

@Ethan-Arrowood Could you review the code again when available? Thanks !

Archkon · 2026-07-18T04:52:17Z

@Ethan-Arrowood sorry to ping you again but I'm working on multiple pr now so would you review this code and see whether merge this ? Or to tell me something to change or modify ?Thanks!

Archkon · 2026-07-23T05:12:02Z

@Ethan-Arrowood Sorry to keep ping and may I ask you to review this again ? As the what the issue said #64390

this bug also affects other users and has significant impact on the reliability of request-abort handling"

Ethan-Arrowood

Sorry for the delay! GH notifications are a mess these days. This is great work.

nodejs-github-bot · 2026-07-23T20:59:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75070/

Archkon · 2026-07-24T15:13:00Z

@Ethan-Arrowood Could you take a look at these failed tests ?

nodejs-github-bot · 2026-07-24T15:23:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75102/

Ethan-Arrowood · 2026-07-24T15:23:21Z

All flake; I have it retrying now. I'll watch this today and see if we can get it to land for you.

Archkon · 2026-07-26T07:54:55Z

@Ethan-Arrowood Sorry, May I ask whether you was occupied with something :-) ?

Ethan-Arrowood · 2026-07-27T14:09:44Z

Simply wasn't at my computer any longer. Will you rebase on main ? It may make things more reliable.

IncomingMessage 'close' is emitted when request handling completes, not only when the underlying connection is closed. Using that event to abort IncomingMessage.signal makes the signal abort after a request body is read normally. Track the underlying socket close instead, and detach the listener when the request or response completes normally. This keeps the signal from being aborted by normal stream completion or later keep-alive socket closure, while still aborting it when the connection closes during the active request lifecycle. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

nodejs-github-bot · 2026-07-27T15:09:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75204/

nodejs-github-bot · 2026-07-27T18:51:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75221/

Archkon · 2026-07-28T04:07:26Z

@Ethan-Arrowood Could you just rerun the failed github action check? I believe this happened due to flaky test

nodejs-github-bot · 2026-07-28T14:27:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75254/

Ethan-Arrowood · 2026-07-28T14:27:37Z

Yes, I just retried it now. Sorry this is taking some time. CI seemed to have some issues yesterday. I'm also trying to land a PR of my own and its annoyingly taking some time.

nodejs-github-bot · 2026-07-28T19:07:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75263/

Ethan-Arrowood · 2026-07-28T19:33:27Z

If this retry fails I'll do a rebuild instead. Good news, CI seems happier today. I was able to merge my own PR moments ago. Will continue monitoring yours and get it landed 😄

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 9, 2026

Archkon force-pushed the httpfix branch from 6f45558 to 5f09def Compare July 9, 2026 15:48

Ethan-Arrowood requested changes Jul 10, 2026

View reviewed changes

Comment thread lib/_http_incoming.js Outdated

Archkon force-pushed the httpfix branch from 5f09def to b59fee5 Compare July 11, 2026 12:07

Archkon requested a review from Ethan-Arrowood July 11, 2026 12:09

trivikr mentioned this pull request Jul 13, 2026

Http IncomingMessage.signal is always aborted for POST requests #63532

Closed

Archkon mentioned this pull request Jul 21, 2026

req.signal.aborted becomes true after request body parse / stream close in Node 24.18.0 #64390

Open

Ethan-Arrowood approved these changes Jul 23, 2026

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026

Archkon force-pushed the httpfix branch from b59fee5 to 2ced6a6 Compare July 27, 2026 14:13

Ethan-Arrowood approved these changes Jul 27, 2026

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

gurgunday approved these changes Jul 27, 2026

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

Uh oh!

Uh oh!

Conversation

Archkon commented Jul 9, 2026

Uh oh!

nodejs-github-bot commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Archkon commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Archkon commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Archkon commented Jul 23, 2026

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 23, 2026

Uh oh!

Archkon commented Jul 24, 2026

Uh oh!

nodejs-github-bot commented Jul 24, 2026

Uh oh!

Ethan-Arrowood commented Jul 24, 2026

Uh oh!

Archkon commented Jul 26, 2026

Uh oh!

Ethan-Arrowood commented Jul 27, 2026

Uh oh!

nodejs-github-bot commented Jul 27, 2026

Uh oh!

nodejs-github-bot commented Jul 27, 2026

Uh oh!

Archkon commented Jul 28, 2026

Uh oh!

nodejs-github-bot commented Jul 28, 2026

Uh oh!

Ethan-Arrowood commented Jul 28, 2026

Uh oh!

nodejs-github-bot commented Jul 28, 2026

Uh oh!

Ethan-Arrowood commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jul 9, 2026 •

edited

Loading

Archkon commented Jul 14, 2026 •

edited

Loading

Archkon commented Jul 18, 2026 •

edited

Loading